szaszm commented on code in PR #2213:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2213#discussion_r3550823153
##########
libminifi/src/minifi-api.cpp:
##########
@@ -88,6 +88,7 @@ gsl::not_null<const minifi::core::PropertyValidator*>
toPropertyValidator(minifi
case MINIFI_VALIDATOR_UNSIGNED_INTEGER: return
gsl::make_not_null(&minifi::core::StandardPropertyValidators::UNSIGNED_INTEGER_VALIDATOR);
case MINIFI_VALIDATOR_DATA_SIZE: return
gsl::make_not_null(&minifi::core::StandardPropertyValidators::DATA_SIZE_VALIDATOR);
case MINIFI_VALIDATOR_PORT: return
gsl::make_not_null(&minifi::core::StandardPropertyValidators::PORT_VALIDATOR);
+ case MINIFI_VALIDATOR_NUMBER: return
gsl::make_not_null(&minifi::core::StandardPropertyValidators::NUMBER_VALIDATOR);
}
gsl_FailFast();
Review Comment:
if we crash on unknown enum values, then adding another validator later
can't be done without breaking API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
