dan-s1 commented on code in PR #11396:
URL: https://github.com/apache/nifi/pull/11396#discussion_r3552604328
##########
nifi-commons/nifi-hashicorp-vault/src/test/java/org/apache/nifi/vault/hashicorp/TestHashiCorpVaultConfiguration.java:
##########
@@ -148,6 +149,60 @@ public void testBasicProperties() {
this.runTest("http");
}
+ @Test
+ public void testKubernetesClientAuthentication() throws IOException {
+ File k8sAuthProps = null;
+ Path tokenFile = null;
+ try {
+ tokenFile = Files.createTempFile("vault-k8s-token", ".jwt");
Review Comment:
Couldn't you use JUnit 5 `TempDir` and thereby not need the `finally`
statement below since created files are automatically cleaned up by JUnit5.
Ditto for the next test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
