[
https://issues.apache.org/jira/browse/NIFI-16099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18095379#comment-18095379
]
ASF subversion and git services commented on NIFI-16099:
--------------------------------------------------------
Commit f1fbff83f7c7132c7643c28990831dea5cc7a43b in nifi's branch
refs/heads/main from Bob Paulin
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f1fbff83f7c ]
NIFI-16099: Controller Service Provider should be passed to Connectors (#11415)
> Controller Service Provider should be passed to Connectors
> ----------------------------------------------------------
>
> Key: NIFI-16099
> URL: https://issues.apache.org/jira/browse/NIFI-16099
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Bob Paulin
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{StandardFlowManager.createConnector}} builds the connector via
> {{{}ExtensionBuilder{}}}, but the builder chain is missing the
>
> {{.controllerServiceProvider(...)}}
>
> every other builder in the same file uses this call.
> Compare with, for example, {{{}buildProcessorNode{}}},
> {{{}buildControllerServiceNode{}}}, {{{}buildReportingTaskNode{}}},
> {{{}buildFlowAnalysisRuleNode{}}}, {{buildFlowRegistryClient}} — every one of
> them calls:
> {{{}.controllerServiceProvider(flowController.getControllerServiceProvider()){}}}.
>
> {{ExtensionBuilder.buildConnector(...)}} also doesn't
> {{requireNonNull(serviceProvider, ...)}} (unlike every other builder in the
> file), so the null slips silently into the {{StandardConnectorNode}}
> constructor.
>
> This is required for the connector code to use the ControllerServiceProvider
> which will be required for Migrations. SEE
> https://github.com/apache/nifi/pull/11240
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
