martinzink commented on code in PR #2214:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2214#discussion_r3593794211
##########
cmake/MiNiFiOptions.cmake:
##########
@@ -174,6 +174,18 @@ add_minifi_multi_option(MINIFI_ASIO_SOURCE "Retrieves Asio
from provided source"
add_minifi_multi_option(MINIFI_KAFKA_SOURCE "Retrieves librdkafka from
provided source" "BUILD;CONAN" "BUILD")
add_minifi_multi_option(MINIFI_MAGIC_ENUM_SOURCE "Retrieves magic_enum from
provided source" "BUILD;CONAN" "BUILD")
add_minifi_multi_option(MINIFI_OPC_SOURCE "Retrieves open62541 from provided
source" "BUILD;CONAN" "BUILD")
+add_minifi_multi_option(MINIFI_OSSP_UUID_SOURCE "Retrieves ossp-uuid from
provided source" "BUILD;CONAN" "BUILD")
Review Comment:
i think we should introduce a deafult flag, so something like this
```
add_minifi_multi_option(MINIFI_DEFAULT_DEPENDENCY_SOURCE "Retrieves
dependencies from provided source by default" "BUILD;CONAN" "BUILD")
add_minifi_multi_option(MINIFI_LZ4_SOURCE "Retrieves lz4 from provided
source" "BUILD;CONAN" "${MINIFI_DEFAULT_DEPENDENCY_SOURCE}")
add_minifi_multi_option(MINIFI_LIBCURL_SOURCE "Retrieves LibCURL from
provided source" "BUILD;CONAN" "${MINIFI_DEFAULT_DEPENDENCY_SOURCE}")
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
