[ 
https://issues.apache.org/jira/browse/NIFI-16129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18097671#comment-18097671
 ] 

David Young commented on NIFI-16129:
------------------------------------

[~exceptionfactory] Thanks for pointing that out, I hadn't thought about the 
null check. I've mentioned it in the past, I'm used to Kotlin's language level 
null checks.

I don't want to have to litter usage sites with null checks so leaving it alone 
in the majority of cases is probably the best approach, and creating our own 
method (unless it already exists somewhere else in the code) doesn't feel 
appropriate.

I'll close this in favor of a more targeted approach? or should I refine the 
task to be a single module package for now?

> Remove StringUtils#isEmpty(), #isBlank(), etc
> ---------------------------------------------
>
>                 Key: NIFI-16129
>                 URL: https://issues.apache.org/jira/browse/NIFI-16129
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: David Young
>            Priority: Major
>
> Using Commons.lang3 StringUtils#isEmpty, #isBlank and friends are not 
> necessary anymore because Java now provides these functions and are built 
> onto the String class.
> Goal would be to eliminate as many of these usages as possible and evaluate 
> if the dependency would be needed at all. 
> Going to start work in `nifi-web-api` but this should probably be moved to an 
> epic at some point to enable going package by package.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to