adamdebreceni commented on code in PR #2209:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2209#discussion_r3638273636
##########
minifi-api/common/include/minifi-cpp/utils/Id.h:
##########
@@ -46,6 +46,9 @@ class Identifier {
return !isNil();
}
+ Identifier& operator++();
+ Identifier operator++(int);
+
Review Comment:
currently the RocksDbProvenanceRepository uses the event_uuid for key, we
could either bring back the retired SequentialIdGenerator, we could replace the
increment operators with a next() method to not cause confusion, or we could
use an uint64_t (event ordinal) as key
##########
minifi-api/common/include/minifi-cpp/utils/Id.h:
##########
@@ -46,6 +46,9 @@ class Identifier {
return !isNil();
}
+ Identifier& operator++();
+ Identifier operator++(int);
+
Review Comment:
currently the RocksDbProvenanceRepository uses the event_uuid for key, we
could either bring back the retired SequentialIdGenerator, we could replace the
increment operators with a next() method to not cause confusion, or we could
use an uint64_t (event ordinal) as key, which one do you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
