markap14 commented on PR #11435: URL: https://github.com/apache/nifi/pull/11435#issuecomment-5093143039
[claude-opus-4.8] Thanks for the review @pvillard31. On your first point: `BacklogRequestEndpointMerger` no longer re-implements the precision/sum/earliest-timestamp rules. It now converts each reporting `BacklogDTO` back into a `Backlog` and folds the nodes with `Backlog.plus()`, so those combination rules live in exactly one place (the nifi-api `Backlog` type). The only logic that remains in the merger is the cluster-specific policy layered on top — a non-reporting node forces `AT_LEAST` and clears `lastCaughtUp`, and a missing per-node `lastCaughtUp` clears the merged value — plus the DTO display formatting. This is in the commit "NIFI-16046: Delegate cluster backlog merge to Backlog.plus()". On your second point (a framework-provided TTL cache / documented caching pattern for expensive source queries): agreed that's worthwhile, but it's a larger, self-contained addition, so I'd prefer to handle it as a separate follow-up rather than expand the scope of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
