markobean commented on PR #11481:
URL: https://github.com/apache/nifi/pull/11481#issuecomment-5105236077

   > Thanks for looking at this issue @markobean.
   > 
   > On a quick review, the referenced component has a 
`load-balance-icon-active` class applied, which is not defined. Defining that 
class to apply the transform might be the better way forward, as opposed to 
changing the nested definition of `fa-rotate-90`. There also be a better 
transform class that should be applied. I did not see analogous approaches, so 
tagging @mcgilman and @rfellows for review on the optimal approach.
   
   Thanks for the feedback @exceptionfactory. However, the style needs to be in 
`fa-rotate-90` to get the CSS inheritance to work as intended. I tried adding 
the center of rotation to just `load-balance-icon-active` and the behavior 
reverted to the incorrect rotation.
   
   One thing I could do is rename `text.load-balance-icon.fa-rotatate-90` to 
`text.load-balance-icon-active.fa-rotate-90` so that it is a little more clear 
this style belongs to the active glyph.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to