esecules commented on code in PR #11432:
URL: https://github.com/apache/nifi/pull/11432#discussion_r3669896147
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/flow/synchronization/StandardVersionedComponentSynchronizer.java:
##########
@@ -1653,11 +1655,13 @@ private Map<String, String> populatePropertiesMap(final
ComponentNode componentN
|| (versionedDescriptor != null &&
versionedDescriptor.getIdentifiesControllerService());
final boolean sensitive = (descriptor != null &&
descriptor.isSensitive())
|| (versionedDescriptor != null &&
versionedDescriptor.isSensitive());
-
+ final String proposedValue =
proposedProperties.get(propertyName);
+ final ParameterParser parameterParser = new
ExpressionLanguageAgnosticParameterParser();
+ final boolean proposedReferencingParameter =
parameterParser.parseTokens(proposedValue).iterator().hasNext();
Review Comment:
Changed it so that proposedReferencingParameter is a function call and its
last in the && chain so it will be short circuited if its non-service
parameter. I organized it this way so that there is just one default else case
where we assign `proposedValue` to `value`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
