martinzink commented on code in PR #2222:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2222#discussion_r3672398483
##########
behave_framework/src/minifi_behave/core/helpers.py:
##########
@@ -53,31 +62,35 @@ def wait_for_condition(condition: Callable[[], bool],
timeout_seconds: float, ba
if condition():
return True
if bail_condition():
- logging.warning("Bail condition evaluated to 'True', aborting
wait.")
+ logger.warning("Bail condition evaluated to 'True', aborting
wait.")
log_due_to_failure(context)
return False
remaining_time = timeout_seconds - (time.monotonic() - start_time)
sleep_time = min(1.0, remaining_time)
if sleep_time > 0:
time.sleep(sleep_time)
except Exception as ex:
- logging.warning("Exception while waiting for condition: %s", ex)
+ logger.warning("Exception while waiting for condition: %s", ex)
log_due_to_failure(context)
return False
- logging.warning("Timed out after %d seconds while waiting for condition",
timeout_seconds)
+ logger.warning(
+ "Timed out after %d seconds while waiting for condition",
timeout_seconds
+ )
Review Comment:
not new code, but fixed [copilot
review](https://github.com/apache/nifi-minifi-cpp/pull/2222/commits/ea1e14998dae1df0ef3bd8598e2f34bdfacba796)
##########
.github/workflows/ci.yml:
##########
@@ -603,15 +603,15 @@ jobs:
name: minifi_rs_behave
path: minifi_rust/minifi_rs_behave/output
linters:
- name: "C++ lint + Shellcheck + Flake8 + Cargo fmt check + Clippy check"
- runs-on: ubuntu-22.04-arm
+ name: "C++ lint + Shellcheck + Ruff + Cargo fmt check + Clippy check"
+ runs-on: ubuntu-24.04-arm
timeout-minutes: 15
steps:
- id: checkout
uses: actions/checkout@v6
- id: install_deps
- run: sudo apt update && sudo apt install -y flake8
+ run: pipx install ruff
Review Comment:
[extend-exclude](https://github.com/apache/nifi-minifi-cpp/pull/2222/commits/fab2cdafd0aeb3c88fba953b07d6fe81fe20b4af)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
