lordgamez commented on code in PR #2218: URL: https://github.com/apache/nifi-minifi-cpp/pull/2218#discussion_r3673025739
########## cmake/GetSOCI.cmake: ########## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +if(MINIFI_SOCI_SOURCE STREQUAL "CONAN") + message("Using Conan to install SOCI") + find_package(SOCI REQUIRED) + # The Conan package exposes per-backend targets; recreate the SOCI::SOCI + # aggregate target the from-source build provides so consumers are unchanged. + if(NOT TARGET SOCI::SOCI) + add_library(SOCI::SOCI INTERFACE IMPORTED) + target_link_libraries(SOCI::SOCI INTERFACE SOCI::soci_core_static SOCI::soci_odbc_static) + endif() +elseif(MINIFI_SOCI_SOURCE STREQUAL "BUILD") + message("Using CMake to build SOCI from source") + include(Soci) +endif() Review Comment: Using the fetchcontent directive in Soci.cmake always creates the `SOCI::SOCI` aggregate target, so this needs to be recreated in the Conan library usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
