exceptionfactory commented on code in PR #11242:
URL: https://github.com/apache/nifi/pull/11242#discussion_r3706810183
##########
nifi-extension-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java:
##########
@@ -75,6 +76,7 @@
@ReadsAttribute(attribute =
AbstractAMQPProcessor.AMQP_CLUSTER_ID_ATTRIBUTE, description = "The ID of the
AMQP Cluster"),
})
public class PublishAMQP extends AbstractAMQPProcessor<AMQPPublisher> {
+ private static final long MAXIMUM_INPUT_FLOWFILE_SIZE_LIMIT = 128 * 1024 *
1024L;
Review Comment:
Based on the earlier conversation, it sounds like the maximum value should
be 512 MB, not 128 MB.
##########
nifi-extension-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java:
##########
@@ -108,6 +110,16 @@ public class PublishAMQP extends
AbstractAMQPProcessor<AMQPPublisher> {
.allowableValues(DeliveryGuarantee.class)
.defaultValue(DeliveryGuarantee.AT_MOST_ONCE)
.build();
+ public static final PropertyDescriptor MAXIMUM_INPUT_FLOWFILE_SIZE = new
PropertyDescriptor.Builder()
+ .name("Maximum Input FlowFile Size")
+ .description("Maximum size of an input FlowFile that will be read
into memory before publishing. PublishAMQP reads FlowFile content into a byte
array "
+ + "before publishing, so FlowFiles larger than this value
are routed to failure before content is read. Configure this value according to
"
+ + "broker limits and available JVM memory.")
Review Comment:
A multline string can be used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
