exceptionfactory commented on code in PR #11463:
URL: https://github.com/apache/nifi/pull/11463#discussion_r3722453966


##########
nifi-extension-bundles/nifi-standard-services/nifi-oauth2-provider-bundle/nifi-oauth2-provider-service/src/main/java/org/apache/nifi/oauth2/JWTBearerOAuth2AccessTokenProvider.java:
##########
@@ -118,11 +122,32 @@ public class JWTBearerOAuth2AccessTokenProvider extends 
AbstractControllerServic
             .required(true)
             .build();
 
+    public static final PropertyDescriptor ASSERTION_STRATEGY = new 
PropertyDescriptor.Builder()
+            .name("Assertion Strategy")
+            .description("Determines how the RFC 7523 JWT assertion presented 
to the Token Endpoint is produced.")
+            .required(true)
+            .allowableValues(AssertionStrategy.class)
+            .defaultValue(AssertionStrategy.SELF_SIGNED.name())

Review Comment:
   The `.name()` usage here and elsewhere in default values and dependsOn can 
be removed in favor of the direct reference to the enum



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to