Copilot commented on code in PR #100:
URL: https://github.com/apache/nifi-site/pull/100#discussion_r3814628537
##########
content/download/_index.md:
##########
@@ -89,9 +89,10 @@ The Apache NiFi Team strongly encourages users to upgrade to
NiFi 2.
#### Sources
{{< cpp-download-links label="C++ Source" extension=source.tar.gz >}}
#### Binaries
-{{< cpp-download-links label="MiNiFi C++ Linux x86_64"
extension=bin-linux-x86_64.tar.gz >}}
+{{< cpp-download-links label="MiNiFi C++ Linux x86_64"
extension=bin-linux-x86-64.tar.gz >}}
{{< cpp-download-links label="MiNiFi C++ Linux arm64"
extension=bin-linux-arm64.tar.gz >}}
-{{< cpp-download-links label="MiNiFi C++ Windows x86_64" extension=windows.msi
>}}
+{{< cpp-download-links label="MiNiFi C++ Windows x86_64"
extension=bin-win-x86-64.msi >}}
Review Comment:
The labels use the architecture token `x86_64` while the artifact extensions
use `x86-64`. If this is intentional (matching the actual published filenames),
it may still be confusing for users scanning the page. Consider aligning the
label text to the artifact naming (or vice versa) so the architecture is
represented consistently.
##########
content/download/_index.md:
##########
@@ -89,9 +89,10 @@ The Apache NiFi Team strongly encourages users to upgrade to
NiFi 2.
#### Sources
{{< cpp-download-links label="C++ Source" extension=source.tar.gz >}}
#### Binaries
-{{< cpp-download-links label="MiNiFi C++ Linux x86_64"
extension=bin-linux-x86_64.tar.gz >}}
+{{< cpp-download-links label="MiNiFi C++ Linux x86_64"
extension=bin-linux-x86-64.tar.gz >}}
{{< cpp-download-links label="MiNiFi C++ Linux arm64"
extension=bin-linux-arm64.tar.gz >}}
-{{< cpp-download-links label="MiNiFi C++ Windows x86_64" extension=windows.msi
>}}
+{{< cpp-download-links label="MiNiFi C++ Windows x86_64"
extension=bin-win-x86-64.msi >}}
+{{< cpp-download-links label="MiNiFi C++ Native SDK" extension=native-sdk.zip
>}}
Review Comment:
These shortcode parameters pass unquoted string values that contain `-` and
`.` characters. Depending on Hugo/shortcode parsing rules and future edits,
this can be brittle. Consider quoting the `extension` values consistently
(e.g., `extension=\"bin-linux-x86-64.tar.gz\"`) to make parsing unambiguous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
