rfellows commented on code in PR #11559:
URL: https://github.com/apache/nifi/pull/11559#discussion_r3831864549
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/parameter-contexts/state/parameter-context-listing/parameter-context-listing.effects.ts:
##########
@@ -338,6 +351,78 @@ export class ParameterContextListingEffects {
map((parameterContexts) =>
parameterContexts.filter((pc) => pc.id != parameterContextId))
);
editDialogReference.componentInstance.saving$ =
this.store.select(selectSaving);
+
editDialogReference.componentInstance.hasPendingPostUpdateNavigation$ =
this.store.select(
+ selectHasPendingPostUpdateNavigation
+ );
+
+ const navigateToInheritedParameter = (
Review Comment:
Extracted. They are now `navigateToInheritedParameter(...)` and
`goToInheritedParameter(...)` private methods on
`ParameterContextListingEffects`, taking the source parameter context id and
the edit dialog reference as arguments rather than closing over them. The
`openParameterContextDialog$` body is about 50 lines shorter as a result.
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/parameter-table/parameter-table.component.ts:
##########
@@ -74,11 +82,15 @@ export class ParameterTable implements AfterViewInit,
ControlValueAccessor {
private store = inject<Store<ParameterContextListingState>>(Store);
Review Comment:
Intentionally out of scope here. This PR adds the capability —
`highlightedParameterName` on the Parameter Context edit route — and consumes
it for inherited-parameter navigation within the Parameter Context editor.
Wiring the property table's existing link to it (extracting the parameter name
from the reference, threading it through `goToParameter`, and resolving the
reference through inherited contexts so the highlight lands in the context that
actually defines the parameter) is tracked in
[NIFI-16240](https://issues.apache.org/jira/browse/NIFI-16240). That is also
what the existing TODO in `PropertyTable.canGoToParameter` refers to. I have
noted the boundary in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
