exceptionfactory commented on code in PR #11593:
URL: https://github.com/apache/nifi/pull/11593#discussion_r3863694617
##########
nifi-extension-bundles/nifi-smb-bundle/nifi-smb-smbj-common/src/main/java/org/apache/nifi/smb/common/SmbProperties.java:
##########
@@ -36,6 +39,34 @@ public class SmbProperties {
public static final String OLD_ENABLE_DFS_PROPERTY_NAME = "enable-dfs";
public static final String OLD_TIMEOUT_PROPERTY_NAME = "timeout";
+ public enum AuthenticationType implements DescribedValue {
+ USERNAME_PASSWORD("Username / Password", "Use username and password to
authenticate"),
Review Comment:
Minor naming recommendation, I would go with `Password` instead of `Username
/ Password` since `Password` refers more directly to the authentication
mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
