MikeThomsen commented on code in PR #11595: URL: https://github.com/apache/nifi/pull/11595#discussion_r3876736924
########## nifi-extension-bundles/nifi-cql-bundle/nifi-scylladb-session-provider-service/pom.xml: ########## @@ -0,0 +1,183 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>nifi-cql-bundle</artifactId> + <groupId>org.apache.nifi</groupId> + <version>2.12.0-SNAPSHOT</version> + </parent> + <modelVersion>4.0.0</modelVersion> + + <artifactId>nifi-scylladb-session-provider-service</artifactId> + <packaging>jar</packaging> + + <dependencies> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-utils</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-cql-services-api</artifactId> + <version>2.12.0-SNAPSHOT</version> + <scope>provided</scope> + </dependency> + + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-cassandra-session-provider-service</artifactId> + <version>2.12.0-SNAPSHOT</version> + <exclusions> + <exclusion> + <groupId>org.apache.cassandra</groupId> + <artifactId>java-driver-core</artifactId> + </exclusion> + </exclusions> + </dependency> + + <dependency> + <groupId>com.scylladb</groupId> + <artifactId>java-driver-core</artifactId> + <version>4.19.2.0</version> + </dependency> + + <!-- + Declared explicitly rather than inherited: the shade plugin below folds the Cassandra service's + classes into this artifact, and those classes use the query builder, so it has to be on this NAR's + runtime classpath in its own right. It previously arrived via nifi-cql-services-api-nar, which is + exactly the leak that put the driver on the backend-agnostic modules' classpath. + + The DataStax core artifact is excluded because ScyllaDB's shard-aware fork below supplies the same + com.datastax.oss.driver.api.core packages; keeping both would put two copies on the classpath. + --> + <dependency> + <groupId>org.apache.cassandra</groupId> + <artifactId>java-driver-query-builder</artifactId> + <version>4.19.3</version> + <exclusions> + <exclusion> + <groupId>org.apache.cassandra</groupId> + <artifactId>java-driver-core</artifactId> + </exclusion> + </exclusions> + </dependency> + + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-ssl-context-service-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-framework-api</artifactId> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-mock</artifactId> + </dependency> + + <dependency> + <groupId>org.testcontainers</groupId> + <artifactId>testcontainers-scylladb</artifactId> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>org.testcontainers</groupId> + <artifactId>testcontainers-junit-jupiter</artifactId> + <scope>test</scope> + <version>${testcontainers.version}</version> + </dependency> + + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-record</artifactId> + <scope>compile</scope> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-avro-record-utils</artifactId> + <version>2.12.0-SNAPSHOT</version> + <scope>compile</scope> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-cql-it-common</artifactId> + <version>2.12.0-SNAPSHOT</version> + <classifier>tests</classifier> + <scope>test</scope> + <exclusions> + <exclusion> + <groupId>org.apache.cassandra</groupId> + <artifactId>java-driver-core</artifactId> + </exclusion> + </exclusions> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-ssl-context-service</artifactId> + <version>2.12.0-SNAPSHOT</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.apache.nifi</groupId> + <artifactId>nifi-security-cert-builder</artifactId> + <version>2.12.0-SNAPSHOT</version> + <scope>test</scope> + </dependency> + </dependencies> + + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-shade-plugin</artifactId> Review Comment: I'll put a comment in to make it more explicit but TL;DR yes the scylla version formally depends on the Cassandra JAR because ScyllaDB's claim to developers is that its client interface is a drop-in replacement aside from the Maven coordinates to reference the JARs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
