joewitt commented on PR #11589: URL: https://github.com/apache/nifi/pull/11589#issuecomment-5647966447
Missing test for the headline feature. Tests cover static pipeline, field extract/strip, nested prune, JSON Array, suppress-nulls, and Update. There is no NDJSON FlowFile with two lines and two different pipeline names in one bulk. That is the behavior the PR text sells. No Create case. Docs say Index and Create; tests only use default Index plus Update. Cheap to add. PutElasticsearchRecord is unchanged. Fine if the JIRA is Json-only; say so in the PR so nobody treats it as “ES ingest pipelines are done.” -- Please do rebase while you're at it. We can do that on merge so not dramatic but helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
