[ 
https://issues.apache.org/jira/browse/NIFI-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876738#comment-15876738
 ] 

ASF GitHub Bot commented on NIFI-3294:
--------------------------------------

GitHub user apiri opened a pull request:

    https://github.com/apache/nifi/pull/1525

    NIFI-3294 (0.x) - Adjusting nifi.sh to invoke nifi-env.sh when running as 
ano…

    …ther user such that properties are preserved across environments.
    
    Updating nifi.sh to include improvements by NIFI-2689
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [-] Have you written or updated unit tests to verify your changes?
    - [-] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [-] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [-] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [-] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [-] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apiri/incubator-nifi NIFI-3294-0.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1525.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1525
    
----
commit a0c5334b7bdd3358ae6b4811756d385ca09c454e
Author: Aldrin Piri <ald...@apache.org>
Date:   2017-02-21T21:15:20Z

    NIFI-3294 Adjusting nifi.sh to invoke nifi-env.sh when running as another 
user such that properties are preserved across environments.
    
    Updating nifi.sh to include improvements by NIFI-2689

----


> NiFi will ignore nifi-env properties when running as another user
> -----------------------------------------------------------------
>
>                 Key: NIFI-3294
>                 URL: https://issues.apache.org/jira/browse/NIFI-3294
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Configuration
>    Affects Versions: 1.0.0, 0.7.0, 0.7.1, 1.1.1, 1.0.1
>         Environment: All non-Windows, non-Cygwin OSes
>            Reporter: Aldrin Piri
>            Assignee: Aldrin Piri
>             Fix For: 0.8.0, 1.2.0
>
>
> nifi-env is a script that allows setting of certain properties external to 
> the core run scripts.  However, when sudo is used, the resulting 
> subshell/child process is a separate environment that does not have the 
> needed information that was established in nifi-env.  This needs to be 
> incorporated into the run command such that those properties are preserved.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to