Copilot commented on code in PR #2267:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2267#discussion_r4123775870
##########
minifi_rust/extensions/minifi_enrichment/Cargo.toml:
##########
@@ -0,0 +1,21 @@
+[package]
+name = "minifi_enrichment"
+version = "0.1.0"
+edition = "2024"
+
+[lib]
+crate-type = ["cdylib"]
+
+[dependencies]
+minifi_native = { path = "../../minifi_native" }
+strum = "0.28.0"
+walkdir = "2.5.0"
+rand = "0.10.0"
+hex = "0.4.3"
+strum_macros = "0.28.0"
+lipsum = "0.9.1"
+uuid = { version = "1.24.0", features = ["v4"] }
+
+[dev-dependencies]
+tempfile = "3.22.0"
+filetime = "0.2.26"
Review Comment:
Several dependencies added for the new `minifi_enrichment` crate (e.g.,
`walkdir`, `rand`, `hex`, `lipsum`, and possibly the dev-deps) are not
referenced by any of the new source files in this PR. Unused deps increase
build time and supply-chain surface; please remove anything not needed, or add
the missing code that requires them.
##########
PROCESSORS.md:
##########
@@ -1479,6 +1510,31 @@ In the list below, the names of required properties
appear in bold. Any other pr
| invokehttp.tx.id | success, response, retry, no retry | The
transaction ID that is returned after reading the response |
+## JoinEnrichmentAttributes
+
+### Description
+
+Rejoins the forked FlowFiles coming from ForkEnrichment processor, the
resulting FlowFile will have the Original's content and all attributes from
both of them (prioritizing Enrichment's).
+
+### Properties
+
+In the list below, the names of required properties appear in bold. Any other
properties (not in bold) are considered optional. The table also indicates any
default values, and whether a property supports the NiFi Expression Language.
+
+| Name | Default Value | Allowable Values | Description
|
+|----------------|---------------|------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| Timeout | | | Specifies the maximum
amount of time to wait for the second FlowFile once the first arrives at the
processor, after which point the first FlowFile will be routed to the 'timeout'
relationship. |
+| Max Batch Size | | | The maximum number of
flow files to process at a time. If unset, all FlowFiles will be processed at
once.
|
+
+### Relationships
+
+| Name | Description
|
+|----------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| invalid | Any FlowFiles without the requisite attributes will be routed
here
|
+| joined | The resultant FlowFile with Records joined together from both the
original and enrichment FlowFiles will be routed to this relationship
|
Review Comment:
This description says the joined FlowFile has \"Records joined together\",
but the Rust implementation in this PR merges attributes (and preserves
original content). Update the relationship description to match actual behavior
(attributes merged/prioritized) to avoid misleading users.
##########
minifi-api/include/minifi-api.h:
##########
@@ -43,7 +43,7 @@ extern "C" {
#define MINIFI_PROXY_CONFIGURATION_SERVICE_INTERFACE_PROPERTY_TYPE
"org.apache.nifi.minifi.controllers.ProxyConfigurationServiceInterface"
enum : uint32_t {
- MINIFI_API_VERSION = 2
+ MINIFI_API_VERSION = 3
};
Review Comment:
The PR title references MINIFICPP-2867 (Rust enrichment processors) while
the PR description references MINIFICPP-2889 and session release/add, and the
code changes include a stable API version bump + new stable C API calls. Please
align the PR description (and ideally the title/linked JIRA) with the
implemented API/processor work so reviewers and release notes reflect the
actual scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
