exceptionfactory commented on code in PR #11752:
URL: https://github.com/apache/nifi/pull/11752#discussion_r4167811771
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CryptographicHashContent.java:
##########
@@ -99,6 +104,14 @@ protected List<PropertyDescriptor>
getSupportedPropertyDescriptors() {
return PROPERTY_DESCRIPTORS;
}
+ @OnScheduled
+ public void onScheduled(final ProcessContext context) {
+ final HashAlgorithm algorithm =
HashAlgorithm.fromName(context.getProperty(HASH_ALGORITHM).getValue());
+ if (algorithm.isBlake2()) {
+ deprecationLogger.warn("{} is deprecated for removal",
algorithm.getName());
Review Comment:
That's a good point. Although the deprecation log should be the primary
location for tracking, adding a warning in the Component Log seems reasonable
here. I will push an update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
