mcgilman opened a new pull request, #11798: URL: https://github.com/apache/nifi/pull/11798
…omponents Move the flow-designer create, group, and import dialogs into ui/common so they emit typed requests instead of dispatching page NgRx. Flow-designer effects still own persistence, and the shared request types live in flow-shared. # Summary [NIFI-16449](https://issues.apache.org/jira/browse/NIFI-16449) Move the flow-designer create, group, and import dialogs into `ui/common/component-dialogs` so they can be reused without dispatching flow-designer NgRx actions. - Create Processor, Create Port, Create Process Group, Create Remote Process Group, Create Connection, Group Components, and Import From Registry emit typed requests. They do not inject `Store`. - Flow-designer effects still assign inputs and dispatch the existing actions, including persistence, error banners, temporary-edge cleanup, and `setDragging(false)`. - Shared request types live in `state/flow-shared`. The flow-designer page state does not re-export them. - Create Process Group accepts `supportsParameters`, defaulting to true. When a host sets it to false, the parameter-context selector is hidden and submit sends no parameter context id. The flow designer leaves the default, so unreadable contexts remain disabled options and the current context is selected only when that option is readable. - `CanvasUtils.getConnectableTypeForSource` delegates to the shared helper, matching `getConnectableTypeForDestination`. The existing edit dialogs were already in `ui/common/component-dialogs` and are unchanged. Verified with `npx nx test nifi` (3097 tests), `npx nx run nifi:lint`, and `npx tsc -p apps/nifi/tsconfig.app.json --noEmit`. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - Pull Request based on current revision of the `main` branch - Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
