fgerlits commented on code in PR #2282:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2282#discussion_r4249510335
##########
.github/workflows/memcheck_ci.yml:
##########
@@ -48,16 +48,17 @@ jobs:
if: always()
with:
path: ${{ env.CCACHE_DIR }}
- key: ubuntu-24.04-valgrind-ccache-${{github.ref}}-${{github.sha}}
+ key: ubuntu-26.04-valgrind-ccache-${{github.ref}}-${{github.sha}}
- name: test
id: test
run: |
# Set core file size limit to unlimited
ulimit -c unlimited
- ctest -j$(nproc) -L memchecked -T memcheck
+ ctest -j$(nproc) -T memcheck -LE integration --output-on-failure
working-directory: build
- name: check valgrind output
id: check
+ if: always()
Review Comment:
this step was skipped if the previous step (unit tests) failed; we need to
check the valgrind report files whether the unit tests succeed or fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
