awelless commented on PR #11670: URL: https://github.com/apache/nifi/pull/11670#issuecomment-6147353338
Thanks for the feedback, @markap14. I think it's fine to support only flow versions created after the fix. Comments regarding the suggested approach. 1. I'm going to use process group version id instead of creator id. In that case if the same service is attempted to be created from 2 creators, it always gets the same versioned id, no matter what creator creates it. 2. Before controller service is committed into a newer flow version, we should remove `MIGRATION_CREATED_COMMENT` to treat it normally from now on. In this PR it has to be done manually, I'm considering a follow up where this comment is removed automatically. I'm going to follow the suggested approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
