Copilot commented on code in PR #2285:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2285#discussion_r4283137677
##########
minifi_rust/extensions/minifi_tensor/src/processors/draw_bounding_box.rs:
##########
@@ -43,7 +43,6 @@ pub(crate) const BOUNDING_BOXES: Property<BoundingBoxes> =
Property::new(
y_min, x_max, y_max; coordinates normalised to [0,1] against the image).
Typically the \
attribute produced by an upstream DetectObject or FilterBoundingBoxes
processor.",
)
-.with_default("${enrichment.value}")
.supports_expression_language();
Review Comment:
Removing the default still leaves `Bounding boxes` optional:
`BoundingBoxes::IS_REQUIRED` is `false` in `utils/bounding_box.rs:137`, and
`schedule()` does not read it. With this property unset, the processor can
start, but every incoming FlowFile is routed to failure when
`get_property(&BOUNDING_BOXES)` returns `MissingRequiredProperty`. Set the
schema's required flag to `true` and regenerate both property tables so missing
configuration is rejected before processing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
