Chaffelson opened a new pull request, #11811:
URL: https://github.com/apache/nifi/pull/11811

   # Summary
   
   [NIFI-16464](https://issues.apache.org/jira/browse/NIFI-16464)
   
   Add `STATELESS_GROUP` to the OpenAPI enum on 
`AffectedComponentEntity.referenceType`. The server already produces this 
value, but its omission from the schema causes enum-validating generated 
clients to reject it.
   
   The annotation now matches `AffectedComponentDTO.referenceType`, preserving 
all six existing values. A regression test checks the complete seven-value 
annotation enum.
   
   # Tracking
   
   ### Issue Tracking
   
   - [x] Apache NiFi Jira issue created: NIFI-16464.
   
   ### Pull Request Tracking
   
   - [x] Pull request title and commit message start with NIFI-16464.
   - [x] Single signed commit; GitHub reports the signature as verified.
   
   ### Pull Request Formatting
   
   - [x] Based on the current revision of `apache/nifi:main`.
   - [x] Feature branch with one commit containing the annotation change and 
regression test.
   
   # Verification
   
   ### Build
   
   - [ ] Full `./mvnw clean install -P contrib-check` (not run; scoped commands 
below).
     - [x] JDK 21 used for the scoped checks.
     - [ ] JDK 25 (not run).
   
   Regression command, run twice before and twice after the fix (`-Dscan=false` 
was added after the first run):
   
   ```shell
   ./mvnw -pl :nifi-client-dto -am test -Dtest=TestAffectedComponentEntity 
-Dsurefire.failIfNoSpecifiedTests=false -Dscan=false -B
   ```
   
   Both pre-fix runs failed on the missing enum value; both post-fix runs 
passed.
   
   ```shell
   ./mvnw -pl :nifi-client-dto -am install -P contrib-check 
'-Dsurefire.opts=-Duser.language=en -Duser.country=US' -Dscan=false -B
   ```
   
   Passed across 17 modules: 714 tests reported, zero failures/errors, 8 
skipped; all 17 client DTO tests passed. Checkstyle, RAT and PMD passed. The 
explicit US locale avoids two existing date-format assertions failing under 
`en_GB` (`CST`/`EST` versus GMT offsets); no date code or tests changed.
   
   ```shell
   ./mvnw -pl :nifi-web-api -am install -DskipTests -Dscan=false -B
   ```
   
   Passed across 102 modules. Parsed the newly generated `2.13.0-SNAPSHOT` 
OpenAPI JSON and verified that both reference-type enums contain exactly the 
seven expected values, including `STATELESS_GROUP`. Tests were skipped only for 
this packaging/schema build.
   
   ### Licensing
   
   No new dependencies; dependency compatibility and `LICENSE`/`NOTICE` updates 
are not applicable.
   
   ### Documentation
   
   No handwritten documentation changes. Generated OpenAPI JSON was checked; 
rendered documentation was not visually inspected.
   
   # Merge risk
   
   The change only expands schema metadata for a value the server already uses; 
runtime behaviour is unchanged. Review the getter annotation and 
`TestAffectedComponentEntity`. The two-file change can be reverted together.
   
   Generated with [Snowflake 
CoCo](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to