kubaugust opened a new pull request, #11817: URL: https://github.com/apache/nifi/pull/11817
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-16467](https://issues.apache.org/jira/browse/NIFI-16467) Schema inference on JSON with deeply nested records of differing shape takes time exponential in the nesting depth. `DataTypeUtils.mergeDataTypes` and `DataTypeSet.add` call `getWiderType` before merging two RECORD types. When neither record is wider, `getWiderRecordType` runs `isRecordWider` in both directions, and each direction recurses into the nested records, so the cost doubles at every level. A single 38-level rich text document was enough to keep inference running for hours. Changes: - `DataTypeUtils.mergeDataTypes`: the RECORD and ARRAY of RECORD merge introduced in NIFI-15745 now runs before the wider type check. Merging is linear in the size of the schemas. - `DataTypeSet.add`: RECORD pairs and ARRAY of RECORD pairs are merged through `mergeDataTypes` before the wider type check. This covers a CHOICE containing a deep record or record array merged with another one. Behavior change: when a later record has a superset of an earlier record's fields, the merged schema keeps first-seen field order with new fields appended, and fields present on one side only are nullable. Previously the wider record was used as-is. This matches the existing top-level record merge behavior. Field types are unchanged. Tests: - `TestDataTypeUtils`: 40-level nested records, a CHOICE of nested records, and a CHOICE of nested record arrays. - `TestJsonSchemaInference`: end-to-end inference of a 40-level nested JSON document. All four new tests time out (10 s, preemptive) without the fix and complete in milliseconds with it. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - [ ] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 Module tests pass for `nifi-record`, `nifi-record-path`, `nifi-json-record-utils`, `nifi-avro-record-utils` and `nifi-record-serialization-services`, and `-P contrib-check` passes for the changed modules. ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
