markap14 opened a new pull request, #11824: URL: https://github.com/apache/nifi/pull/11824
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-16478](https://issues.apache.org/jira/browse/NIFI-16478) When a field's schema is a CHOICE between an array of strings and a nested array of records, `DataTypeUtils.chooseDataType` can select the array of strings. Any `Object[]` is considered String-compatible, and re-inferring the value's type does not match either choice, so the method falls back to the first compatible choice. Each inner array is then written as a string such as `"[[Ljava.lang.Object;@4613311f]"`. This shows up, for example, with ConsumeKafka and "Continue with Merged Schema" when one message has an empty array and another has nested arrays of records for the same field. When no choice is a clear match, `chooseDataType` now picks the first compatible choice that does not convert nested arrays, collections, or maps into Strings, and only falls back to the first compatible choice if none qualifies. The new check runs only in that fallback, so the cost is unchanged when there is a single compatible choice or when the inferred type already matches a choice. Tests: - `TestDataTypeUtils.testChooseDataTypeForNestedArraysInChoice`: nested arrays with empty and populated branches, in both choice orders. - `TestWriteJsonResult.testChoiceArrayOfStringsOrNestedArraysOfRecordsFromMergedSchemas`: schemas inferred separately for an empty array and for nested arrays of records, merged, and written as JSON. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - Pull Request based on current revision of the `main` branch - Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
