Nhyeongrakji opened a new pull request, #11832:
URL: https://github.com/apache/nifi/pull/11832

   <!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
   <!-- contributor license agreements.  See the NOTICE file distributed with 
-->
   <!-- this work for additional information regarding copyright ownership. -->
   <!-- The ASF licenses this file to You under the Apache License, Version 2.0 
-->
   <!-- (the "License"); you may not use this file except in compliance with -->
   <!-- the License.  You may obtain a copy of the License at -->
   <!--     http://www.apache.org/licenses/LICENSE-2.0 -->
   <!-- Unless required by applicable law or agreed to in writing, software -->
   <!-- distributed under the License is distributed on an "AS IS" BASIS, -->
   <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied. -->
   <!-- See the License for the specific language governing permissions and -->
   <!-- limitations under the License. -->
   
   # Summary
   
   [NIFI-16485](https://issues.apache.org/jira/browse/NIFI-16485) adds an 
optional `Max Poll Records` property to `ConsumeKafka`. When set, it overrides 
the `max.poll.records` value of the Kafka Connection Service for that 
Processor. When not set, the Connection Service value applies, so existing 
flows are unchanged.
   
   | Property | Default | Description |
   |---|---|---|
   | Max Poll Records | none | Maximum number of records returned from a single 
poll of Kafka. Overrides the Max Poll Records property of the Kafka Connection 
Service for this Processor. |
   
   Changes:
   
   - `PollingContext` carries an optional Max Poll Records value through new 
constructors. The existing constructors are unchanged.
   - `ConsumeKafka` passes the property value in `PollingContext`.
   - `Kafka3ConnectionService.getConsumerService` applies the value after the 
service consumer properties.
   - Added `ConsumeKafkaTest` cases for validation and for the value passed in 
`PollingContext`, and a `Kafka3ConnectionServiceBaseIT` case where the service 
sets 10 and the `PollingContext` sets 2, verifying that a single poll returns 2 
records.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-00000`
   - Pull Request commit message starts with Apache NiFi Jira issue number, as 
such `NIFI-00000`
   - Pull request contains [commits 
signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
 with a registered key indicating `Verified` status
   
   ### Pull Request Formatting
   
   - Pull Request based on current revision of the `main` branch
   - Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [x] Build completed using `./mvnw clean install -P contrib-check` (for 
`nifi-extension-bundles/nifi-kafka-bundle`)
     - [x] JDK 21
     - [ ] JDK 25
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to