pvillard31 commented on code in PR #11831:
URL: https://github.com/apache/nifi/pull/11831#discussion_r4359576971
##########
nifi-connector-mock-bundle/nifi-connector-mock-api/src/main/java/org/apache/nifi/mock/connector/server/ConnectorTestRunner.java:
##########
@@ -194,6 +194,22 @@ default void stopConnector(final Duration timeout) throws
TimeoutException {
*/
List<ValidationResult> validate();
+ default Long getCounterValue(final String componentId, final String name) {
Review Comment:
Can we add Javadoc for these four methods, describing the null or empty
return when nothing was recorded, and the sum versus exact attribute match
behavior?
##########
nifi-connector-mock-bundle/nifi-connector-mock-api/src/main/java/org/apache/nifi/mock/connector/server/ConnectorTestRunner.java:
##########
@@ -194,6 +194,22 @@ default void stopConnector(final Duration timeout) throws
TimeoutException {
*/
List<ValidationResult> validate();
+ default Long getCounterValue(final String componentId, final String name) {
+ throw new UnsupportedOperationException();
Review Comment:
Should the UnsupportedOperationException include a short message saying this
runner does not support component metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
