Vinz2168 commented on PR #11791: URL: https://github.com/apache/nifi/pull/11791#issuecomment-6381016899
@vd-rd sorry for the delay! Agreed: keeping this PR as is, with the limitation documented the same way as for the Bitbucket and Azure DevOps clients, sounds reasonable to me. The final call on merging belongs to the committers, though. I raised [NIFI-16501](https://issues.apache.org/jira/browse/NIFI-16501) for the `StandardHttpUriBuilder` change. No current caller of `addQueryParameter()` encodes values beforehand, so encoding there should be safe and would also lift the limitation for the Bitbucket, Azure DevOps and Gitea clients. Once it is merged, the documented limitation can be removed from all three. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
