bobpaulin commented on code in PR #11872:
URL: https://github.com/apache/nifi/pull/11872#discussion_r4482088630
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/components/connector/StandardConnectorRepository.java:
##########
@@ -733,6 +918,61 @@ private void waitForState(final ConnectorNode connector,
final Set<ConnectorStat
}
}
+ private void waitForFlowEvolutionStatus(final ConnectorNode connector,
final FlowEvolutionStatus desiredStatus)
Review Comment:
The timeout and the logging upgrade on the wait makes sense. Will update.
On the related point Node A can only cross into saving the new node if all
nodes complete phase 1. That means the Node B failure would have to have
occurred after the drain is confirmed. This should mean a failure would be on
installing the new upgraded flow which can be safely re-triggered. There is no
value in reverting the entire cluster back to the old flow if the drain is
successful. At this point we need to fail forward. If the failure were to
occur before phase 1 I completely agree that all nodes need to still be on the
snapshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
