anshuksi282-ksolves opened a new pull request, #11890:
URL: https://github.com/apache/nifi/pull/11890

   ## Summary
   
   [NIFI-16548](https://issues.apache.org/jira/browse/NIFI-16548)
   
   While resizing a property editor, the CDK moves the handle and the editor 
grows at the same time, so the handle runs ahead of the pointer and the pointer 
ends up over the editor's Ok button. When Ok is disabled (no changes yet), the 
browser does not dispatch the mouseup on the disabled button, so the CDK drag 
never ends and the editor keeps resizing with the mouse until the next click.
   
   This adds a transparent ::after layer over the editor while the resize 
handle is dragging, so the mouseup reaches the document and the drag ends. The 
layer is removed as soon as the drag ends. The change applies to all editors 
that use the Resizable component.
   
   This is the follow-up to #11827, split out per review. The two changes touch 
different parts of the file and merge cleanly together.
   
   ## Tracking
   
   ### Issue Tracking
   
   - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [x] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-00000`
   - [x] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-00000`
   - [x] Pull request contains [commits 
signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
 with a registered key indicating `Verified` status
   
   ### Pull Request Formatting
   
   - [x] Pull Request based on current revision of the `main` branch
   - [x] Pull Request refers to a feature branch with one commit containing 
changes
   
   ## Verification
   
   ### Build
   
   - [ ] Build completed using `./mvnw clean install -P contrib-check`
     - [ ] JDK 21
     - [ ] JDK 25
   
   Verified with nx build nifi, nx lint shared, Prettier, and the resizable 
spec. Checked in a running NiFi (ExecuteSQL, SQL Query editor): with Ok 
disabled, releasing the handle after a resize now ends the drag in every 
direction tried, and the editor stays usable afterwards.
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   No new dependencies were added.
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   
   No documentation files were changed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to