mattcasters commented on PR #11660: URL: https://github.com/apache/nifi/pull/11660#issuecomment-6736241807
I rechecked this against current `main` (`62e4d95a82`, NIFI-16554). The behavior described in NIFI-16326 is already fixed on main by NIFI-16226, which shipped in NiFi 2.12.0. - Update analysis in `StandardNiFiServiceFacade.setEffectiveParameterUpdates()` now sets `inherited=true` from the source Parameter Context before the update is stored. - `StandardParameterContextDAO.getParameters()` already skips parameters with `inherited=true`, so those effective values are not written as local parameters. - A later reorder, add, or remove therefore recalculates the effective value instead of keeping the value from the first inheritance change. The UI sends an empty parameter list when only the inheritance list changes. That is the same request the system test in this PR sends. With NIFI-16226, that path no longer persists a local override. This PR still adds a DAO guard for a request that omits the `inherited` flag but names a different Parameter Context as the source. The UI and the normal REST update do not send that payload. Pierre Villard also ran the related NIFI-16278 steps on the 2.12.0 release candidate and saw the expected behavior. Closing this pull request. NIFI-16326 is resolved as a duplicate of NIFI-16226. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
