lordgamez commented on code in PR #2298: URL: https://github.com/apache/nifi-minifi-cpp/pull/2298#discussion_r4514668078
########## cmake/RapidJSON.cmake: ########## @@ -0,0 +1,33 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +include(FetchContent) + +set(RAPIDJSON_BUILD_TESTS OFF CACHE BOOL "" FORCE) +set(RAPIDJSON_BUILD_EXAMPLES OFF CACHE BOOL "" FORCE) +set(RAPIDJSON_BUILD_DOC OFF CACHE BOOL "" FORCE) + +FetchContent_Declare( + rapidjson_src + GIT_REPOSITORY https://github.com/Tencent/rapidjson.git + GIT_TAG 297637bc0a0f00dc504dbc1a47ebdaa577f8ae19 + SYSTEM +) +FetchContent_MakeAvailable(rapidjson_src) + +add_library(rapidjson INTERFACE) Review Comment: FetchContent_Populate is deprecated since CMake 3.30, using a non-existent SOURCE_SUBDIR avoids running add_subdirectory() and only downloads the source files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
