lordgamez commented on code in PR #2299:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2299#discussion_r4522783675


##########
.github/workflows/ci.yml:
##########
@@ -688,10 +688,12 @@ jobs:
         uses: actions/checkout@v6
 
       - id: install_deps
-        run: pipx install ruff
+        run: |
+          pipx install ruff && \
+          wget 
https://archive.apache.org/dist/creadur/apache-rat-0.18/apache-rat-0.18-bin.tar.gz
 -O ~/apache-rat-0.18-bin.tar.gz && tar -xzf ~/apache-rat-0.18-bin.tar.gz -C ~/

Review Comment:
   Updated in 
https://github.com/apache/nifi-minifi-cpp/pull/2299/commits/2c23b79b9aaf5974c69ad9bc1d2b698b4416595e



##########
.github/workflows/ci.yml:
##########
@@ -722,8 +724,15 @@ jobs:
         run: cargo clippy --workspace --all-targets -- -D warnings
         working-directory: minifi_rust
 
+      - id: apache_rat_check
+        name: Apache RAT check
+        continue-on-error: true
+        run: |
+          make rat

Review Comment:
   Updated in 
https://github.com/apache/nifi-minifi-cpp/pull/2299/commits/2c23b79b9aaf5974c69ad9bc1d2b698b4416595e



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to