exceptionfactory commented on code in PR #11897:
URL: https://github.com/apache/nifi/pull/11897#discussion_r4530697702
##########
nifi-system-tests/nifi-system-test-suite/src/test/resources/conf/clustered/node1/nifi.properties:
##########
@@ -198,7 +198,7 @@ nifi.cluster.protocol.heartbeat.interval=2 sec
# cluster node properties (only configure for cluster nodes) #
nifi.cluster.is.node=true
nifi.cluster.node.address=
-nifi.cluster.node.protocol.port=48101
+nifi.cluster.node.protocol.port=6351
Review Comment:
Is there a reason for this change, or can it be reverted?
##########
nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/NiFiSystemIT.java:
##########
@@ -468,6 +468,22 @@ protected void waitFor(final ExceptionalBooleanSupplier
condition, final long de
logger.info("Wait successful for {}", description);
}
+ /**
+ * Waits for the condition to be met on each node of the cluster in turn,
with the client switched to that node. Conditions that
+ * inspect node-specific state must issue their requests with {@link
#DO_NOT_REPLICATE}, because replicated responses are merged
+ * and may reflect only one node. The client is switched back to the
default node before returning.
+ */
+ protected void waitForOnAllNodes(final ExceptionalBooleanSupplier
condition, final String description) throws InterruptedException {
+ try {
+ for (int nodeIndex = 1; nodeIndex <= getNumberOfNodes();
nodeIndex++) {
Review Comment:
It looks like this only works when the test is working with a cluster. That
seems it a little less obvious based on the method naming, so I would either
move this method to the specific test class, or make sure it can handle a
standalone instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
