exceptionfactory commented on code in PR #11841:
URL: https://github.com/apache/nifi/pull/11841#discussion_r4558948002
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/java/org/apache/nifi/events/VolatileBulletinRepositoryTest.java:
##########
@@ -267,4 +268,18 @@ private int getBulletinCount() {
List<Bulletin> bulletins = repository.findBulletins(query);
return bulletins.size();
}
+
+ @Test
+ public void testProcessGroupBulletinsIncludeControllerServiceBulletins() {
Review Comment:
This test method should be moved directly after other test methods, before
any private methods
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/java/org/apache/nifi/events/VolatileBulletinRepositoryTest.java:
##########
@@ -267,4 +268,18 @@ private int getBulletinCount() {
List<Bulletin> bulletins = repository.findBulletins(query);
return bulletins.size();
}
+
+ @Test
+ public void testProcessGroupBulletinsIncludeControllerServiceBulletins() {
Review Comment:
It would be helpful to add one test where the groupId is `null` to exercise
Controller-level Services
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
