exceptionfactory commented on code in PR #11905:
URL: https://github.com/apache/nifi/pull/11905#discussion_r4589537765


##########
nifi-extension-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/test/java/org/apache/nifi/parquet/ParquetTestUtils.java:
##########
@@ -111,6 +113,10 @@ public static File createAllTemporalTypesParquetFile(int 
numRecords, File direct
         final Schema timeMicrosSchema = 
LogicalTypes.timeMicros().addToSchema(Schema.create(Schema.Type.LONG));
         final Schema timestampMillisSchema = 
LogicalTypes.timestampMillis().addToSchema(Schema.create(Schema.Type.LONG));
         final Schema timestampMicrosSchema = 
LogicalTypes.timestampMicros().addToSchema(Schema.create(Schema.Type.LONG));
+        final Schema timestampNanosSchema = 
LogicalTypes.timestampMicros().addToSchema(Schema.create(Schema.Type.LONG));
+        final Schema localTimestampMillisSchema = 
LogicalTypes.timestampMillis().addToSchema(Schema.create(Schema.Type.LONG));
+        final Schema localTimestampMicrosSchema = 
LogicalTypes.timestampMicros().addToSchema(Schema.create(Schema.Type.LONG));
+        final Schema localTimestampNanosSchema = 
LogicalTypes.timestampMicros().addToSchema(Schema.create(Schema.Type.LONG));

Review Comment:
   These method calls do not use the corresponding `localTimestamp` methods 
from `LogicalTypes`, so they do not exercise the updated handling



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to