pvillard31 commented on code in PR #11932:
URL: https://github.com/apache/nifi/pull/11932#discussion_r4658311916
##########
nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/coordination/node/TestNodeClusterCoordinator.java:
##########
@@ -522,6 +523,34 @@ public void
testConnectionRequestCancelsPendingDisconnect() throws InterruptedEx
assertFalse(disconnectThread.isAlive());
}
+ @Test
+ public void
testNotifyNodeStatusListenersReportsCurrentStatesWithoutChangingThem() {
+ final NodeIdentifier connectedNodeId = createNodeId(1);
+ final NodeIdentifier offloadingNodeId = createNodeId(2);
+ coordinator.updateNodeStatus(new NodeConnectionStatus(connectedNodeId,
NodeConnectionState.CONNECTED));
+ coordinator.updateNodeStatus(new
NodeConnectionStatus(offloadingNodeId, NodeConnectionState.OFFLOADING));
+ final NodeConnectionStatus connectedStatusBefore =
coordinator.getConnectionStatus(connectedNodeId);
+ final NodeConnectionStatus offloadingStatusBefore =
coordinator.getConnectionStatus(offloadingNodeId);
+
+ final ClusterTopologyEventListener listener =
Mockito.mock(ClusterTopologyEventListener.class);
+ coordinator.registerEventListener(listener);
+
+ coordinator.notifyNodeStatusListeners();
+
+ Mockito.verify(listener,
Mockito.times(1)).onNodeStateChange(connectedNodeId,
NodeConnectionState.CONNECTED);
+ Mockito.verify(listener,
Mockito.times(1)).onNodeStateChange(offloadingNodeId,
NodeConnectionState.OFFLOADING);
+ Mockito.verify(listener, Mockito.times(2)).onNodeStateChange(any(),
any());
+ Mockito.verify(listener, Mockito.never()).onNodeAdded(any());
+ Mockito.verify(listener, Mockito.never()).onNodeRemoved(any());
Review Comment:
Done, thanks @exceptionfactory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]