Github user jdye64 commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/54#discussion_r102845154
  
    --- Diff: libminifi/CMakeLists.txt ---
    @@ -36,12 +36,23 @@ ENDIF(POLICY CMP0048)
     set(CMAKE_CXX_STANDARD 11)
     set(CMAKE_CXX_STANDARD_REQUIRED ON)
     
    +include(CheckCXXCompilerFlag)
    +CHECK_CXX_COMPILER_FLAG("-std=c++11" COMPILER_SUPPORTS_CXX11)
    +CHECK_CXX_COMPILER_FLAG("-std=c++0x" COMPILER_SUPPORTS_CXX0X)
    +if(COMPILER_SUPPORTS_CXX11)
    +    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -g")
    +elseif(COMPILER_SUPPORTS_CXX0X)
    +    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
    +else()
    + message(STATUS "The compiler ${CMAKE_CXX_COMPILER} has no C++11 support. 
Please use a different C++ compiler.")
    +endif()
    +
     include_directories(../include)
     include_directories(../thirdparty/yaml-cpp-yaml-cpp-0.5.3/include)
     include_directories(../thirdparty/civetweb-1.9.1/include)
     include_directories(include)
     
    -file(GLOB SOURCES "src/*.cpp")
    +file(GLOB_RECURSE SOURCES "src/*.cpp")
    --- End diff --
    
    Will think conflict with conditional builds like in 
https://github.com/apache/nifi-minifi-cpp/pull/52/files#diff-2672ba1ce10995865ff39a95c67bc5dcR72
 since those features are in fact subdirectories of src?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to