Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1564#discussion_r104315947
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ScanAttribute.java
---
@@ -151,24 +182,41 @@ public void onScheduled(final ProcessContext context)
throws IOException {
this.dictionaryTerms = createDictionary(context);
this.fileWatcher = new
SynchronousFileWatcher(Paths.get(context.getProperty(DICTIONARY_FILE).getValue()),
new LastModifiedMonitor(), 1000L);
+
+ this.dictionaryEntryMetadataDemarcator =
context.getProperty(DICTIONARY_ENTRY_METADATA_DEMARCATOR).getValue();
}
- private Set<String> createDictionary(final ProcessContext context)
throws IOException {
- final Set<String> terms = new HashSet<>();
+ private Map<String,String> createDictionary(final ProcessContext
context) throws IOException {
+ final Map<String,String> termsMeta = new HashMap<String, String>();
+ this.dictionaryEntryMetadataDemarcator =
context.getProperty(DICTIONARY_ENTRY_METADATA_DEMARCATOR).getValue();
+
+ String[] termMeta;
+ String term;
--- End diff --
Consider moving lines 194 and 195 to line 207 (tightest scope possible) and
marking their declarations as final since they're defined in an if/else.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
