[
https://issues.apache.org/jira/browse/NIFI-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907689#comment-15907689
]
ASF GitHub Bot commented on NIFI-3204:
--------------------------------------
Github user francoisprunier commented on the issue:
https://github.com/apache/nifi/pull/1561
Hi @joewitt,
I've successfully tested your patch. The thing I'm concerned about is the
change of behaviour when no incoming flow is connected to the processor, which
breaks the contract existing users of the processor may rely on.
Before:
- incoming flow: creates one flow file per deleted file: BROKEN when more
than one file deleted
- no incoming flow: creates one flow file per deleted file per run: WORKS
After:
- incoming flow: "creates" only one flow file per incoming flowfile: WORKS
when more than one file deleted
- no incoming flow: creates only one flow file per run: WORKS but behaviour
is changed
On the one hand I like your approach better, but on the other hand breaking
users' flows is not great.
> delete hdfs processor throws an error stating transfer relationship not
> specified even when all relationships are present
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-3204
> URL: https://issues.apache.org/jira/browse/NIFI-3204
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.0.0, 1.1.0
> Reporter: Arpit Gupta
> Assignee: Joseph Witt
> Attachments:
> 0001-NIFI-3204-applies-after-pr1561-aeab1feeb3c5f47858793.patch
>
>
> Following flow was setup
> get file -> extract text -> delete hdfs
> A bunch of files were written each having one line which was the path to
> delete. Some of these path's were files, some were directories and some were
> patterns. Extract text would extract the line and assign to an attribute
> which delete hdfs would use to populate the path to delete.
> However the processor would run into an error when ever it tried to process
> the path which was a pattern matching multiple paths.
> {code}
> 2016-12-14 11:32:43,335 ERROR [Timer-Driven Process Thread-7]
> o.a.nifi.processors.hadoop.DeleteHDFS
> DeleteHDFS[id=fed0acf6-0158-1000-b7ab-8cc724e4142d]
> DeleteHDFS[id=fed0acf6-0158-1000-b7ab-8cc724e4142d] failed to process session
> due to org.apache.nifi.processor.exception
> .FlowFileHandlingException:
> StandardFlowFileRecord[uuid=af8be94a-e527-4203-bb87-a0115f84e582,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1481656798897-1, container=default,
> section=1], offset=6518, length=75],offset=0,name=noyg3p7km8.txt,size=75] tr
> ansfer relationship not specified:
> org.apache.nifi.processor.exception.FlowFileHandlingException:
> StandardFlowFileRecord[uuid=af8be94a-e527-4203-bb87-a0115f84e582,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1481656798897-1, container=default,
> sectio
> n=1], offset=6518, length=75],offset=0,name=noyg3p7km8.txt,size=75] transfer
> relationship not specified
> 2016-12-14 11:32:43,335 ERROR [Timer-Driven Process Thread-7]
> o.a.nifi.processors.hadoop.DeleteHDFS
> org.apache.nifi.processor.exception.FlowFileHandlingException:
> StandardFlowFileRecord[uuid=af8be94a-e527-4203-bb87-a0115f84e582,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1481656798897-1, container=default,
> section=1], offset=6518, length=75],offse
> t=0,name=noyg3p7km8.txt,size=75] transfer relationship not specified
> at
> org.apache.nifi.controller.repository.StandardProcessSession.checkpoint(StandardProcessSession.java:234)
> ~[nifi-framework-core-1.1.0.jar:1.1.0]
> at
> org.apache.nifi.controller.repository.StandardProcessSession.commit(StandardProcessSession.java:304)
> ~[nifi-framework-core-1.1.0.jar:1.1.0]
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:28)
> ~[nifi-api-1.1.0.jar:1.1.0]
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1099)
> ~[nifi-framework-core-1.1.0.jar:1.1.0]
> at
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:136)
> [nifi-framework-core-1.1.0.jar:1.1.0]
> at
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47)
> [nifi-framework-core-1.1.0.jar:1.1.0]
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:132)
> [nifi-framework-core-1.1.0.jar:1.1.0]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> [na:1.8.0_92]
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> [na:1.8.0_92]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> [na:1.8.0_92]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> [na:1.8.0_92]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [na:1.8.0_92]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_92]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_92]
> 2016-12-14 11:32:43,335 WARN [Timer-Driven Process Thread-7]
> o.a.nifi.processors.hadoop.DeleteHDFS
> DeleteHDFS[id=fed0acf6-0158-1000-b7ab-8cc724e4142d] Processor
> Administratively Yielded for 1 sec due to processing failure
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
