[ 
https://issues.apache.org/jira/browse/NIFI-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941059#comment-15941059
 ] 

ASF GitHub Bot commented on NIFI-1705:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1589#discussion_r107989450
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java
 ---
    @@ -0,0 +1,280 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.nifi.processors.standard;
    +
    +import org.apache.commons.lang3.StringEscapeUtils;
    +import org.apache.commons.lang3.StringUtils;
    +import org.apache.nifi.annotation.behavior.EventDriven;
    +import org.apache.nifi.annotation.behavior.SideEffectFree;
    +import org.apache.nifi.annotation.behavior.SupportsBatching;
    +import org.apache.nifi.annotation.behavior.InputRequirement;
    +import org.apache.nifi.annotation.behavior.WritesAttribute;
    +import org.apache.nifi.annotation.documentation.CapabilityDescription;
    +import org.apache.nifi.annotation.documentation.Tags;
    +import org.apache.nifi.annotation.lifecycle.OnScheduled;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.flowfile.FlowFile;
    +import org.apache.nifi.flowfile.attributes.CoreAttributes;
    +import org.apache.nifi.processor.AbstractProcessor;
    +import org.apache.nifi.processor.ProcessContext;
    +import org.apache.nifi.processor.ProcessorInitializationContext;
    +import org.apache.nifi.processor.ProcessSession;
    +import org.apache.nifi.processor.Relationship;
    +import org.apache.nifi.processor.exception.ProcessException;
    +import org.apache.nifi.processor.util.StandardValidators;
    +
    +
    +import java.io.BufferedOutputStream;
    +import java.io.OutputStream;
    +import java.util.Arrays;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.ArrayList;
    +import java.util.Set;
    +import java.util.HashSet;
    +import java.util.Map;
    +import java.util.Collections;
    +import java.util.stream.Collectors;
    +
    +@EventDriven
    +@SideEffectFree
    +@SupportsBatching
    +@Tags({"csv", "attributes", "flowfile"})
    +@InputRequirement(InputRequirement.Requirement.INPUT_REQUIRED)
    +@CapabilityDescription("Generates a CSV representation of the input 
FlowFile Attributes. The resulting CSV " +
    +        "can be written to either a newly generated attribute named 
'CSVAttributes' or written to the FlowFile as content.  " +
    +        "If the attribute value contains a comma, newline or double quote, 
then the attribute value will be " +
    +        "escaped with double quotes.  Any double quote characters in the 
attribute value are escaped with " +
    +        "another double quote.  If the attribute value does not contain a 
comma, newline or double quote, then the " +
    +        "attribute value is returned unchanged.")
    +@WritesAttribute(attribute = "CSVAttributes", description = "CSV 
representation of Attributes")
    +public class AttributesToCSV extends AbstractProcessor {
    +
    +    private static final String OUTPUT_NEW_ATTRIBUTE = 
"flowfile-attribute";
    +    private static final String OUTPUT_OVERWRITE_CONTENT = 
"flowfile-content";
    +    private static final String OUTPUT_ATTRIBUTE_NAME = "CSVAttributes";
    +    private static final String OUTPUT_SEPARATOR = ",";
    +    private static final String OUTPUT_MIME_TYPE = "text/csv";
    +
    +
    +    public static final PropertyDescriptor ATTRIBUTES_LIST = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    Is there any value in supporting a regular expression or (alternatively) 
supporting Expression Language for the Attribute List property? For the former, 
I'm thinking of the use case where there might be an arbitrary number of 
attributes available, often with the same prefix. For the latter (I doubt we'd 
want to support both), I'm thinking of the case (if it exists) where the CSV 
column names might themselves be in an attribute, where their values might be 
in the corresponding attribute(s). That second one seems pretty much an edge 
case, I just wanted to bring these up for discussion. If neither seems 
particularly useful, then I'm good with the comma-separated list of attributes 
:)


> AttributesToCSV
> ---------------
>
>                 Key: NIFI-1705
>                 URL: https://issues.apache.org/jira/browse/NIFI-1705
>             Project: Apache NiFi
>          Issue Type: Sub-task
>          Components: Extensions
>            Reporter: Randy Gelhausen
>
> Create a new processor which converts a Flowfile's attributes into CSV 
> content.
> Should support the same configuration options as the AttributesToJSON 
> processor



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to