[ 
https://issues.apache.org/jira/browse/NIFI-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949168#comment-15949168
 ] 

ASF subversion and git services commented on NIFI-3636:
-------------------------------------------------------

Commit 3aa1db6ee5d952aa67601e460331940f5e20a166 in nifi's branch 
refs/heads/master from [~markap14]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=3aa1db6 ]

NIFI-3636: Lazily copy FlowFile Attributes Hash Map instead of doing so eagerly.

Signed-off-by: Matt Burgess <[email protected]>

NIFI-3257: Added additional logging regarding timing information when 
replicating requests across cluster in order to glean insight as to what is 
taking so long when replicating some requests

Signed-off-by: Matt Burgess <[email protected]>

NIFI-3649: Buffer node responses when replicating HTTP Requests up to a maximum 
buffer size

Signed-off-by: Matt Burgess <[email protected]>

NIFI-3636: Added unit test to ensure that flowfile attribute maps are copied 
when appropriate

Signed-off-by: Matt Burgess <[email protected]>

NIFI-3636: Removed patch file that should not have been in commit

Signed-off-by: Matt Burgess <[email protected]>

This closes #1612


> Session should not copy FlowFile Attribute Map when creating new FlowFile 
> object unless attributes are changing
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-3636
>                 URL: https://issues.apache.org/jira/browse/NIFI-3636
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>             Fix For: 1.2.0
>
>
> Currently, each time we create a new FlowFile object, we do so using 
> StandardFlowFileRecord.Builder and then call fromFlowFile(FlowFile). This 
> copies the attributes map of the given FlowFile. We should instead just set 
> the member variable of the builder to point at the same Map object as the 
> given FlowFile and keep a flag indicating whether or not this was done. If 
> this is done, we must lazily copy the hash map before modifying it. 
> Otherwise, we can point to the same Map object.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to