Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1645#discussion_r109728311
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase/HBase_1_1_2_ClientMapCacheService.java
 ---
    @@ -0,0 +1,224 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.hbase;
    +
    +import java.io.ByteArrayOutputStream;
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +import org.apache.nifi.annotation.documentation.CapabilityDescription;
    +import org.apache.nifi.annotation.documentation.SeeAlso;
    +import org.apache.nifi.annotation.documentation.Tags;
    +import org.apache.nifi.annotation.lifecycle.OnEnabled;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.controller.AbstractControllerService;
    +import org.apache.nifi.controller.ConfigurationContext;
    +
    +import org.apache.nifi.distributed.cache.client.DistributedMapCacheClient;
    +import org.apache.nifi.distributed.cache.client.Serializer;
    +import org.apache.nifi.distributed.cache.client.Deserializer;
    +import java.io.ByteArrayOutputStream;
    +import org.apache.nifi.reporting.InitializationException;
    +
    +import java.nio.charset.StandardCharsets;
    +import org.apache.nifi.hbase.scan.ResultCell;
    +import org.apache.nifi.hbase.scan.ResultHandler;
    +import org.apache.nifi.hbase.scan.Column;
    +import org.apache.nifi.hbase.put.PutColumn;
    +
    +
    +import org.apache.nifi.processor.util.StandardValidators;
    +
    +@Tags({"distributed", "cache", "state", "map", "cluster","hbase"})
    +@SeeAlso(classNames = 
{"org.apache.nifi.distributed.cache.server.map.DistributedMapCacheClient", 
"org.apache.nifi.hbase.HBase_1_1_2_ClientService"})
    +@CapabilityDescription("Provides the ability to use an HBase table as a 
cache, in place of a DistributedMapCache."
    +    + " Uses a HBase_1_1_2_ClientService controller to communicate with 
HBase.")
    +
    +public class HBase_1_1_2_ClientMapCacheService extends 
AbstractControllerService implements DistributedMapCacheClient {
    +
    +    static final PropertyDescriptor HBASE_CLIENT_SERVICE = new 
PropertyDescriptor.Builder()
    +        .name("HBase Client Service")
    +        .description("Specifies the HBase Client Controller Service to use 
for accessing HBase.")
    +        .required(true)
    +        .identifiesControllerService(HBaseClientService.class)
    +        .build();
    +
    +    public static final PropertyDescriptor HBASE_CACHE_TABLE_NAME = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    For the table, col fal, and col qual, you may want to support expression 
language. There are obviously no flow files in this case, but if you have 
expressionLanguageSupported(true) on the property descriptors and then when you 
get the values .evaluateAttributeExpressions(), this would let someone 
reference an environment variable if they want to specify a different table 
across environments,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to