Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1610#discussion_r110472437
--- Diff:
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/NotificationServiceManager.java
---
@@ -420,15 +424,15 @@ public static Element getChild(final Element element,
final String tagName) {
}
private static class ConfiguredNotificationService {
- private final NotificationService service;
+ private final AbstractNotificationService service;
private final Map<String, String> properties;
- public ConfiguredNotificationService(final NotificationService
service, final Map<String, String> properties) {
+ public ConfiguredNotificationService(final
AbstractNotificationService service, final Map<String, String> properties) {
--- End diff --
why go from the interface to the abstract implementation here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
