Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r111775350
  
    --- Diff: libminifi/include/core/Processor.h ---
    @@ -239,12 +242,21 @@ class Processor : public Connectable, public 
ConfigurableComponent,
       // Trigger the Processor even if the incoming connection is empty
       std::atomic<bool> _triggerWhenEmpty;
     
    - private:
    +  //! obtainSite2SiteProtocol for use
    +  std::shared_ptr<Site2SiteClientProtocol> 
obtainSite2SiteProtocol(std::string host, uint16_t sport, uuid_t portId);
    --- End diff --
    
    @benqiu2016 Can you make a ticket to move this out of Processor? It should 
be a separate component. If you make the ticket I'll make this particular 
change. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to