[
https://issues.apache.org/jira/browse/NIFI-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972496#comment-15972496
]
ASF GitHub Bot commented on NIFI-2697:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/1679
NIFI-2697: Fix opening Remote Ports dialog.
If there is an unconnected remote port, right clicking a Remote Process
Group
then select 'Remote Ports' causes a JS error saying 'Uncaught TypeError'.
Because there are few code paths those don't return the created
transmissionSwitch value from createPortOption function in
nf-remote-process-group-ports.js.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-2697
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1679.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1679
----
commit ee5687b275443628003fb69cb6d573687fd60a42
Author: ijokarumawak <ijokaruma...@apache.org>
Date: 2017-04-18T10:54:37Z
NIFI-2697: Fix opening Remote Ports dialog.
If there is an unconnected remote port, right clicking a Remote Process
Group
then select 'Remote Ports' causes a JS error saying 'Uncaught TypeError'.
Because there are few code paths those don't return the created
transmissionSwitch value from createPortOption function in
nf-remote-process-group-ports.js.
----
> UI - Revert RemoteProcessGroup Port configuration on failed update request
> --------------------------------------------------------------------------
>
> Key: NIFI-2697
> URL: https://issues.apache.org/jira/browse/NIFI-2697
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core UI
> Reporter: Matt Gilman
> Assignee: Scott Aslan
> Priority: Minor
> Fix For: 1.2.0
>
>
> Another follow up to NIFI-2687 [1] is that when the request to update a
> RemoteProcessGroup Port fails, the values in the UI do not revert to their
> previously configured values. Another option (for the configuration dialog)
> may be to keep the dialog open until there is a successful response.
> [1] https://issues.apache.org/jira/browse/NIFI-2687
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
