[
https://issues.apache.org/jira/browse/NIFI-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986732#comment-15986732
]
ASF GitHub Bot commented on NIFI-3749:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1708
NIFI-3749: Added database filtering to DDL events in CaptureChangeMySQL
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-3749
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1708.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1708
----
----
> CaptureChangeMySQL should filter Query and XID events by database regex
> -----------------------------------------------------------------------
>
> Key: NIFI-3749
> URL: https://issues.apache.org/jira/browse/NIFI-3749
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.2.0
> Reporter: Koji Kawamura
> Assignee: Matt Burgess
>
> Although Query events including BEGIN/COMMIT and DDL statements do not have
> corresponding TableMap event, they still have 'database' name. So, it's
> possible to apply 'database' filter regex to filter out unnecessary events.
> Currently, Queries executed against a database which is not in interest can
> generate FlowFiles, and it can cause unexpected behavior.
> When we fix this, we should be careful about XID event and 'inTransaction'
> flag as XID event only has transaction id, we may need to add checking
> 'skipTable', too.
> Also, we need to pass database to DDLEventInfo.tableInfo to write database
> name into outgoing FlowFile.
> Finally, Begin/CommitTransactionEventInfo currently don't have database
> property or TableInfo in it. Adding database property to these class might be
> a right approach.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
